-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use u8 in more places #69995
Use u8 in more places #69995
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsPrimarily replacing Encoding.UTF8/ASCII.GetBytes("literal") with "literal"u8.ToArray() Updates the pinned version of the C# compiler we're using so that we pick up recent updates to the u8 feature.
|
07dd6d7
to
af7ee78
Compare
9ec81fb
to
0acf732
Compare
One more, if you are interested in throwing it in this PR: Line 14 in c12bea8
You could probably get rid of that property entirely and change line 30 to: if (rawData.IndexOf("-----BEGIN "u8) < 0) (Assuming my understanding is correct that the |
@tannergooding, this pulls in an updated C# compiler, and there are a fair number of failures in UIntPtr-related tests, e.g.
There are some commented out tests there: runtime/src/libraries/System.Runtime/tests/System/DoubleTests.GenericMath.cs Lines 1871 to 1873 in 748dfb7
with a comment to a Roslyn bug recently fixed, but I'm assuming the tests that aren't commented out are expected to continue working? So far all the failures I've seen have been on Unix on mono. |
Same as for #70087 (comment)
|
Primarily replacing Encoding.UTF8/ASCII.GetBytes("literal") with "literal"u8.ToArray()
Primarily replacing Encoding.UTF8/ASCII.GetBytes("literal") with "literal"u8.ToArray()
Updates the pinned version of the C# compiler we're using so that we pick up recent updates to the u8 feature.